[all-commits] [llvm/llvm-project] 9a8b04: Reapply "[lld] enable fixup chains by default (#79...

Daniel Bertalan via All-commits all-commits at lists.llvm.org
Mon Jul 22 13:03:53 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9a8b0407fc16af4ca6f79a2583297318a645d88a
      https://github.com/llvm/llvm-project/commit/9a8b0407fc16af4ca6f79a2583297318a645d88a
  Author: Daniel Bertalan <dani at danielbertalan.dev>
  Date:   2024-07-22 (Mon, 22 Jul 2024)

  Changed paths:
    M lld/MachO/Driver.cpp
    M lld/docs/ReleaseNotes.rst
    M lld/test/MachO/arm64-32-stubs.s
    M lld/test/MachO/arm64-stubs.s
    M lld/test/MachO/dyld-stub-binder.s
    M lld/test/MachO/invalid/chained-fixups-incompatible.s
    M lld/test/MachO/objc-selrefs.s

  Log Message:
  -----------
  Reapply "[lld] enable fixup chains by default (#79894)" (#99255)

This reverts commit f55b79f59a77b4be586d649e9ced9f8667265011.

The known issues with chained fixups have been addressed by #98913,
#98305, #97156 and #95171.

Compared to the original commit, support for xrOS (which postdates
chained fixups' introduction) was added and an unnecessary test change
was removed.

----------
Original commit message:

Enable chained fixups in lld when all platform and version criteria are
met. This is an attempt at simplifying the logic used in ld 907:


https://github.com/apple-oss-distributions/ld64/blob/93d74eafc37c0558b4ffb88a8bc15c17bed44a20/src/ld/Options.cpp#L5458-L5549

Some changes were made to simplify the logic:
- only enable chained fixups for macOS from 13.0 to avoid the arch check
- only enable chained fixups for iphonesimulator from 16.0 to avoid the
arch check
- don't enable chained fixups for not specifically listed platforms
- don't enable chained fixups for arm64_32



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list