[all-commits] [llvm/llvm-project] a63417: [InstrPGO][TypeProf]Annotate vtable types when the...

[Mingming Liu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a6341718967a708149159e8583549fa15198f902
      https://github.com/llvm/llvm-project/commit/a6341718967a708149159e8583549fa15198f902
  Author: Mingming Liu <mingmingl at google.com>
  Date:   2024-07-22 (Mon, 22 Jul 2024)

  Changed paths:
    M compiler-rt/test/profile/Linux/instrprof-vtable-value-prof.cpp
    M llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp

  Log Message:
  -----------
  [InstrPGO][TypeProf]Annotate vtable types when they are present in the profile (#99402)

Before this change, when `file.profdata` have vtable profiles but `--enable-vtable-value-profiling` is not on for optimized build, warnings from this line [1] will show up. They are benign for performance but confusing.

It's better to automatically annotate vtable profiles if `file.profdata` has them. This PR implements it in profile use pass.
* If `-icp-max-num-vtables` is zero (default value is 6), vtable profiles won't be annotated.

[1] https://github.com/llvm/llvm-project/blob/464d321ee8dde1eaf14b5537eaf030e6df513849/llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp#L1762-L1768



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications