[all-commits] [llvm/llvm-project] 85e742: [mlir][vector] Refactor vector-transfer-flatten.ml...

[Andrzej Warzyński via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 85e74285626191108a78e797179374219b3a67d4
      https://github.com/llvm/llvm-project/commit/85e74285626191108a78e797179374219b3a67d4
  Author: Andrzej Warzyński <andrzej.warzynski at arm.com>
  Date:   2024-07-22 (Mon, 22 Jul 2024)

  Changed paths:
    M mlir/test/Dialect/Vector/vector-transfer-flatten.mlir

  Log Message:
  -----------
  [mlir][vector] Refactor vector-transfer-flatten.mlir (nfc) (3/n) (#95745)

The main goal of this and subsequent PRs is to unify and categorize
tests in:
  * vector-transfer-flatten.mlir

This should make it easier to identify the edge cases being tested (and
how they differ), remove duplicates and to add tests for scalable
vectors.

The main contributions of this PR:

1. For consistency with other tests,
   `@transfer_read_flattenable_with_dynamic_dims_and_indices` is renamed
   as `@transfer_read_leading_dynamic_dims`. It is also moved near other
   tests for `xfer_read`, variable names are updated to match other
   `xfer_read` tests

2. `@transfer_write_dims_mismatch_non_zero_indices_trailing_dynamic_dim`
   is renamed as `@negative_transfer_read_dynamic_dim_to_flatten` to
   better highlight that it's a negative test and to contrast it with
   `@transfer_read_leading_dynamic_dims` (and to emphasise the
   difference between the two).

3. Similar changes for tests for `xfer_write`.

4. Make sure that we consistently use `%idx_N` (as opposed to `%idxN`).

Follow-up for #95743 and #95744



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications