[all-commits] [llvm/llvm-project] aa86f4: [MC] Remove unnecessary DWARFMustBeAtTheEnd check

Fangrui Song via All-commits all-commits at lists.llvm.org
Sat Jul 20 10:44:14 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: aa86f4f18549583f9227276cd116dbaf5625aa78
      https://github.com/llvm/llvm-project/commit/aa86f4f18549583f9227276cd116dbaf5625aa78
  Author: Fangrui Song <i at maskray.me>
  Date:   2024-07-20 (Sat, 20 Jul 2024)

  Changed paths:
    M llvm/include/llvm/MC/TargetRegistry.h
    M llvm/lib/CodeGen/LLVMTargetMachine.cpp
    M llvm/lib/MC/MCMachOStreamer.cpp
    M llvm/lib/Target/AArch64/MCTargetDesc/AArch64MCTargetDesc.cpp
    M llvm/lib/Target/ARM/MCTargetDesc/ARMMCTargetDesc.cpp

  Log Message:
  -----------
  [MC] Remove unnecessary DWARFMustBeAtTheEnd check

36a15cb975334403216e6145d4abece3026af17a introduced the
DWARFMustBeAtTheEnd check to ensure DWARF sections were placed after all
text sections to help avoid out-of-range branches for Darwin ARM. The
commit removed a Darwin ARM hack from
20e5f5ed7930efdf2bd34bf099f24ac88798c5ea (2009), likely due to a
no-longer-relevant assembler limitation.

However, this check is no longer relevant due to the following:

* Our CodeGen approach reliably places DWARF sections at the end.
* Darwin AArch32 is less relevant today.

Removing this check also addresses a minor clang cc1as crash that could
occur when text sections were placed after DWARF sections
(e9ad54b3ee905ea3a77c35ca7d6e843b2c552e0b (2015)).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list