[all-commits] [llvm/llvm-project] 867ff2: [lit] Add a flag to disable lit time tests (#98270)

Vincent Lee via All-commits all-commits at lists.llvm.org
Sat Jul 20 00:13:42 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 867ff2d4268ca7eed89a24f100b67b68f5329439
      https://github.com/llvm/llvm-project/commit/867ff2d4268ca7eed89a24f100b67b68f5329439
  Author: Vincent Lee <thevinster at users.noreply.github.com>
  Date:   2024-07-20 (Sat, 20 Jul 2024)

  Changed paths:
    M llvm/docs/CommandGuide/lit.rst
    M llvm/utils/lit/lit/cl_arguments.py
    M llvm/utils/lit/lit/main.py
    A llvm/utils/lit/tests/Inputs/time-tests/a.txt
    A llvm/utils/lit/tests/Inputs/time-tests/lit.cfg
    A llvm/utils/lit/tests/time-tests.py

  Log Message:
  -----------
  [lit] Add a flag to disable lit time tests (#98270)

LLVM lit assumes control of the test parallelism when running a test
suite. This style of testing doesn't play nicely with build systems like
Buck or Bazel since it prefers finer grained actions on a per-test
level. In order for external build systems to control the test
parallelism, add an option to disable `.lit_test_times.txt` under the
`--skip-test-time-recording` flag, thus allowing other build systems 
to determine the parallelism and avoid race conditions when writing 
to that file. I went for `--skip-test-time-recording` instead of `--time-tests` in 
order to preserve the original functionality of writing to `.lit_test_times.txt`
as the default behavior and only opt-in for those who do _not_ want
`.lit_test_times.txt` file.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list