[all-commits] [llvm/llvm-project] 2ea4a0: Fix test assertions in TestDAP_stepInTargets.py (#...

Kendal Harland via All-commits all-commits at lists.llvm.org
Tue Jul 16 03:59:30 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2ea4a03c0f1be6dd11428e4c6eb840b745116ca2
      https://github.com/llvm/llvm-project/commit/2ea4a03c0f1be6dd11428e4c6eb840b745116ca2
  Author: Kendal Harland <3987220+kendalharland at users.noreply.github.com>
  Date:   2024-07-16 (Tue, 16 Jul 2024)

  Changed paths:
    M lldb/test/API/tools/lldb-dap/stepInTargets/TestDAP_stepInTargets.py
    M lldb/test/API/tools/lldb-dap/stepInTargets/main.cpp

  Log Message:
  -----------
  Fix test assertions in TestDAP_stepInTargets.py (#96687)

The strings this test is using seem to consistently fail to match
against the expected values when built & run targeting Windows amd64.
This PR updates them to the expected values.

To fix the test and avoid over-specifying for a specific platform, use
`assertIn(<target-substring>,...)` to see if we've got the correct
target label instead of comparing the demangler output for an exact
string match.

---------

Co-authored-by: kendal <kendal at thebrowser.company>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list