[all-commits] [llvm/llvm-project] 44d969: Private process events were being delivered to the...

jimingham via All-commits all-commits at lists.llvm.org
Mon Jul 15 15:07:23 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 44d9692e6a657ec46e98e4912ac56417da67cfee
      https://github.com/llvm/llvm-project/commit/44d9692e6a657ec46e98e4912ac56417da67cfee
  Author: jimingham <jingham at apple.com>
  Date:   2024-07-15 (Mon, 15 Jul 2024)

  Changed paths:
    M lldb/include/lldb/Target/Process.h
    M lldb/include/lldb/Utility/Event.h
    M lldb/source/Target/Process.cpp
    M lldb/source/Utility/Event.cpp
    M lldb/test/API/python_api/event/TestEvents.py

  Log Message:
  -----------
  Private process events were being delivered to the secondary listener (#98571)

This fixes a bug where Process events were being delivered to secondary
listeners when the Private state thread listener was processing the
event. That meant the secondary listener could get an event before the
Primary listener did. That in turn meant the state when the secondary
listener got the event wasn't right yet. Plus it meant that the
secondary listener saw more events than the primary (not all events get
forwarded from the private to the public Process listener.)

This bug became much more evident when we had a stop hook that did some
work, since that delays the Primary listener event delivery. So I also
added a stop-hook to the test, and put a little delay in as well.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list