[all-commits] [llvm/llvm-project] d4216b: [clang][CodeGen][AMDGPU] Enable AMDGPU `printf` fo...

[Alex Voicu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d4216b5d0b111879f153c53caecf8ea011296cec
      https://github.com/llvm/llvm-project/commit/d4216b5d0b111879f153c53caecf8ea011296cec
  Author: Alex Voicu <alexandru.voicu at amd.com>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M clang/lib/CodeGen/CGBuiltin.cpp
    M clang/lib/CodeGen/CGGPUBuiltin.cpp
    M clang/test/CodeGenHIP/printf-builtin.hip
    M clang/test/CodeGenHIP/printf.cpp
    M llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.cpp

  Log Message:
  -----------
  [clang][CodeGen][AMDGPU] Enable AMDGPU `printf` for `spirv64-amd-amdhsa` (#97132)

This enables the AMDGPU specific implementation of `printf` when
compiling for AMDGCN flavoured SPIR-V, the consequence being that the
expansion into ROCDL calls & friends gets expanded before "lowering" to
SPIR-V and gets carried through. The only relatively "novel" aspect is
that the `callAppendStringN` is simplified to take the type of the
passed in arguments, as opposed to querying them from the module. This
is a neutral change since the arguments were passed directly to the
call, without any attempt to cast them, hence the assumption that the
actual types match the formal ones was already baked in.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications