[all-commits] [llvm/llvm-project] b298e2: [LLD] [MinGW] Reinstate the former spelling in the...

[Martin Storsjö via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b298e2d2d2251767a5ddcdef2310494d3b8da773
      https://github.com/llvm/llvm-project/commit/b298e2d2d2251767a5ddcdef2310494d3b8da773
  Author: Martin Storsjö <martin at martin.st>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M lld/MinGW/Driver.cpp
    M lld/test/MinGW/driver.test

  Log Message:
  -----------
  [LLD] [MinGW] Reinstate the former spelling in the version message (#97698)

0f9fbbb63cfcd2069441aa2ebef622c9716f8dbb changed the version printouts.
This broke linker detection in Meson, when disambiguating between the
ld.lld and lld-link interfaces, in

https://github.com/mesonbuild/meson/blob/1.4.1/mesonbuild/linkers/detect.py#L67,
which checks for the string "(compatible with GNU linkers)" including
the parentheses.

Reinstate the parentheses in the printout here, for compatibility with
Meson. The printout looks a little odd in this form, "LLD 19.0.0
(https://github.com/llvm/llvm-project
173514d58ec4e6166670f1e37a038df3865c8b96) (compatible with GNU
linkers)", but works with Meson.

The Meson check is loosened in https://github.com/mesonbuild/meson/pull/13383,
but existing versions of Meson with the too strict check will be around
for quite some time, so we should only change LLD to the new form once
older versions of Meson aren't used for these targets any longer, i.e.
earliest within a few years.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications