[all-commits] [llvm/llvm-project] e975ff: [X86] matchAddressRecursively - don't fold zext(sh...

Simon Pilgrim via All-commits all-commits at lists.llvm.org
Thu Jul 4 13:03:35 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e975ff0a223e79842b693e0ec4d3cac87963869a
      https://github.com/llvm/llvm-project/commit/e975ff0a223e79842b693e0ec4d3cac87963869a
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2024-07-04 (Thu, 04 Jul 2024)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelDAGToDAG.cpp
    M llvm/test/CodeGen/X86/addr-mode-matcher-3.ll
    M llvm/test/CodeGen/X86/sttni.ll
    M llvm/test/CodeGen/X86/var-permute-128.ll

  Log Message:
  -----------
  [X86] matchAddressRecursively - don't fold zext(shl(x,c)) -> shl(zext(x),c)) if the pattern has multiple uses

Fixes #97533 crash where we hit a case where the root node had referenced the original zext node, which we then deleted - hopefully I can come up with a better solution, but the codegen changes don't look too bad atm (pulls out a shift from some complex LEA nodes that shared the scaled index).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list