[all-commits] [llvm/llvm-project] a1bc60: [Flang][Transform] Modify stack reclaim pass to us...

[agozillon via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a1bc606b5fb9a91eb16fc0c012aa785323788c90
      https://github.com/llvm/llvm-project/commit/a1bc606b5fb9a91eb16fc0c012aa785323788c90
  Author: agozillon <Andrew.Gozillon at amd.com>
  Date:   2024-07-03 (Wed, 03 Jul 2024)

  Changed paths:
    M flang/lib/Optimizer/Transforms/StackReclaim.cpp
    M flang/test/Transforms/stack-reclaime.fir

  Log Message:
  -----------
  [Flang][Transform] Modify stack reclaim pass to use allocation address space when generating intrinsics (#96836)

This PR aims to factor in the allocation address space provided by an
architectures data layout when generating the intrinsic instructions,
this allows them to be lowered later with the address spaces in tow.
This aligns the intrinsic creation with the LLVM IRBuilder's
https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/IR/IRBuilder.h#L1053

This is also necessary for the below example to compile for OpenMP AMD
GPU and not ICE the compiler in ISEL as AMD's stackrestore and stacksave
are expected to have the appropriate allocation address space for AMD
GPU.

program main
    integer(4), allocatable :: test
    allocate(test)

!$omp target map(tofrom:test)
    do i = 1, 10
      test = test + 50
    end do
!$omp end target

  deallocate(test)
end program

The PR also fixes the issue I opened a while ago which hits the same
error when compiling for AMDGPU:
https://github.com/llvm/llvm-project/issues/82368

Although, you have to have the appropriate GPU LIBC and Fortran offload
runtime (both compiled for AMDGPU) added to the linker for the command
or it will reach another ISEL error and ICE weirdly. But with the
pre-requisites it works fine with this PR.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications