[all-commits] [llvm/llvm-project] c156d4: [RISCV] Remove SeenExtMap from RISCVISAInfo::parse...

Craig Topper via All-commits all-commits at lists.llvm.org
Wed Jul 3 11:49:29 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c156d421851d175805309a83bf703ad304955847
      https://github.com/llvm/llvm-project/commit/c156d421851d175805309a83bf703ad304955847
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2024-07-03 (Wed, 03 Jul 2024)

  Changed paths:
    M clang/test/Driver/riscv-arch.c
    M llvm/lib/TargetParser/RISCVISAInfo.cpp

  Log Message:
  -----------
  [RISCV] Remove SeenExtMap from RISCVISAInfo::parseArchString. (#97506)

Use the Exts map directly instead of adding to a temporary MapVector
first.

There are a couple functional change from this.
-If an unknown extension is duplicated, we will now print an error for
it being unknown instead of an error for it being duplicated. 
-If an unknown extension is followed by an underscore with no extension after
it, we will error for the unknown extension instead of the dangling
underscore.

These don't seem like serious changes to me. I've updated tests
accordingly.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list