[all-commits] [llvm/llvm-project] a01765: [lldb][DataFormatter][NFC] Factor out MapIterator ...

[Michael Buch via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a0176533766201eca58b20a11e42ab30c73d1b1b
      https://github.com/llvm/llvm-project/commit/a0176533766201eca58b20a11e42ab30c73d1b1b
  Author: Michael Buch <michaelbuch12 at gmail.com>
  Date:   2024-07-03 (Wed, 03 Jul 2024)

  Changed paths:
    M lldb/source/Plugins/Language/CPlusPlus/LibCxxMap.cpp

  Log Message:
  -----------
  [lldb][DataFormatter][NFC] Factor out MapIterator logic into separate helper (#97544)

This patch factors all the logic for advancing the `MapIterator` out of
`GetChildAtIndex`. This, in my opinion, helps readability, and will be
useful for upcoming cleanups in this area.

While here, some drive-by changes:
* added a couple of clarification comments
* fixed a variable name typo
* turned the `return lldb::ValueObjectSP()` into `return nullptr`
* added an assertion to make sure we keep the iterator cache in a valid
state



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications