[all-commits] [llvm/llvm-project] 845dee: SBThread::StepInstruction shouldn't discard other ...

jimingham via All-commits all-commits at lists.llvm.org
Wed Jul 3 10:45:42 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 845dee36ba4161df153ba05009cea615e20eda5a
      https://github.com/llvm/llvm-project/commit/845dee36ba4161df153ba05009cea615e20eda5a
  Author: jimingham <jingham at apple.com>
  Date:   2024-07-03 (Wed, 03 Jul 2024)

  Changed paths:
    M lldb/source/API/SBThread.cpp
    M lldb/test/API/python_api/thread/TestThreadAPI.py
    M lldb/test/API/python_api/thread/main.cpp

  Log Message:
  -----------
  SBThread::StepInstruction shouldn't discard other plans (#97493)

This was just a typo, none of the external execution control functions
should discard other plans. In particular, it means if you stop in a
hand-called function and step an instruction, the function call thread
plan gets unshipped, popping all the function call frames.

I also added a test that asserts the correct behavior. I tested all the
stepping operations even though only StepInstruction was wrong.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list