[all-commits] [llvm/llvm-project] d8c073: [Support] Move raw_ostream::tie to raw_fd_ostream ...

[Alexis Engelke via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d8c07342c021f31f08dee7d15e17f7eca0d1aae0
      https://github.com/llvm/llvm-project/commit/d8c07342c021f31f08dee7d15e17f7eca0d1aae0
  Author: Alexis Engelke <engelke at in.tum.de>
  Date:   2024-07-03 (Wed, 03 Jul 2024)

  Changed paths:
    M clang-tools-extra/clangd/index/remote/server/Server.cpp
    M clang-tools-extra/clangd/tool/ClangdMain.cpp
    M llvm/include/llvm/Support/raw_ostream.h
    M llvm/lib/Support/raw_ostream.cpp
    M llvm/unittests/Support/raw_ostream_test.cpp

  Log Message:
  -----------
  [Support] Move raw_ostream::tie to raw_fd_ostream (#97396)

Originally, tie was introduced by D81156 to flush stdout before writing
to stderr. 030897523 reverted this due to race conditions. Nonetheless,
it does cost performance, causing an extra check in the "cold" path,
which is actually the hot path for raw_svector_ostream. Given that this
feature is only used for errs(), move it to raw_fd_ostream so that it no
longer affects performance of other stream classes.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications