[all-commits] [llvm/llvm-project] 21276f: [MC] Don't treat altentry symbols as atoms

[Fangrui Song via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 21276fd7beb640d5fb1a10c228c9f48f620a8eac
      https://github.com/llvm/llvm-project/commit/21276fd7beb640d5fb1a10c228c9f48f620a8eac
  Author: Fangrui Song <i at maskray.me>
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
    M llvm/lib/MC/MCMachOStreamer.cpp
    M llvm/test/MC/MachO/cfi-advance-loc-err.s

  Log Message:
  -----------
  [MC] Don't treat altentry symbols as atoms

The current `setAtom` is inaccurate: a `.alt_entry` label can also be
recognized as an atom. This is mostly benign, but might cause two
locations only separated by an `.alt_entry` to have different atoms.

https://reviews.llvm.org/D153167 changed a `evaluateKnownAbsolute` to
`evaluateAsAbsolute` and would not fold `A-B` even if they are only
separated by a `.alt_entry` label, leading to a spurious error
`invalid CFI advance_loc expression`.

The fix is similar to #82268: add a special case for `.alt_entry`.

Fix #97116

Pull Request: https://github.com/llvm/llvm-project/pull/97479



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications