[all-commits] [llvm/llvm-project] 3c50cb: [DeviceRTL] Make defined 'libc' functions weak in ...

[Joseph Huber via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3c50cbfda4fc3ad85349167132f7ed809ecc685a
      https://github.com/llvm/llvm-project/commit/3c50cbfda4fc3ad85349167132f7ed809ecc685a
  Author: Joseph Huber <huberjn at outlook.com>
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
    M offload/DeviceRTL/src/Debug.cpp
    M offload/DeviceRTL/src/LibC.cpp

  Log Message:
  -----------
  [DeviceRTL] Make defined 'libc' functions weak in OpenMP (#97356)

Summary:
These functions provide special-case implementations internal to the
OpenMP device runtime. This can potentially conflict with the symbols
pulled in from the actual GPU `libc`. This patch makes these weak, so in
the case that the GPU libc functions exist they will be overridden. This
should not impact performance in the average case because the old
`-mlink-builtin-bitcode` version does internalization, deleting weak,
and the new LTO path will resolve to the strong reference and then
internalize it.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications