[all-commits] [llvm/llvm-project] 184652: [mlir] Make MLIR Python sources idempotent (#97167)

[Brendan Duke via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1846523bb77275de954ac573110171bd39bfa930
      https://github.com/llvm/llvm-project/commit/1846523bb77275de954ac573110171bd39bfa930
  Author: Brendan Duke <brendanw.duke at gmail.com>
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
    M mlir/cmake/modules/AddMLIRPython.cmake

  Log Message:
  -----------
  [mlir] Make MLIR Python sources idempotent (#97167)

Make MLIR Python sources idempotent by moving the custom commands off
the custom target for each source.
Previously, a custom target was created for each MLIR Python source file
and a custom command added to symlink it to a destination path. However
this causes the build to not be idempotent because custom targets always
run.

Instead, this PR separates the symlink/copy to destination paths into
custom commands and makes the custom target depend on the output. That
prevents re-running them and restores idempotency.

Testing:
- Build with `-D MLIR_ENABLE_BINDINGS_PYTHON=ON`. Prior to this change,
the build is not idempotent (building twice re-runs the symlink/copy
command for Python source targets). After this change it is idempotent.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications