[all-commits] [llvm/llvm-project] dd5df2: [lldb] Make semantics of SupportFile equivalence e...

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Mon Jul 1 12:54:57 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dd5df27d9c6b47793b72d4c8f2a796e5d8dc343d
      https://github.com/llvm/llvm-project/commit/dd5df27d9c6b47793b72d4c8f2a796e5d8dc343d
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2024-07-01 (Mon, 01 Jul 2024)

  Changed paths:
    M lldb/include/lldb/Utility/SupportFile.h
    M lldb/source/Breakpoint/BreakpointResolver.cpp
    M lldb/source/Commands/CommandObjectSource.cpp
    M lldb/source/Symbol/LineEntry.cpp
    M lldb/source/Symbol/LineTable.cpp
    M lldb/source/Target/ThreadPlanStepOverRange.cpp
    M lldb/source/Target/ThreadPlanStepRange.cpp
    M lldb/unittests/Utility/CMakeLists.txt
    A lldb/unittests/Utility/SupportFileTest.cpp

  Log Message:
  -----------
  [lldb] Make semantics of SupportFile equivalence explicit (#97126)

This is an improved attempt to improve the semantics of SupportFile
equivalence, taking into account the feedback from #95606.

Pavel's comment about the lack of a concise name because the concept
isn't trivial made me realize that I don't want to abstract this concept
away behind a helper function. Instead, I opted for a rather verbose
enum that forces the caller to consider exactly what kind of comparison
is appropriate for every call.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list