[all-commits] [llvm/llvm-project] 80ffec: [AsmPrinter] Remove timers (#97046)

Alexis Engelke via All-commits all-commits at lists.llvm.org
Mon Jul 1 07:21:17 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 80ffec78848d6ca99e33ebdc4adc415b74f24358
      https://github.com/llvm/llvm-project/commit/80ffec78848d6ca99e33ebdc4adc415b74f24358
  Author: Alexis Engelke <engelke at in.tum.de>
  Date:   2024-07-01 (Mon, 01 Jul 2024)

  Changed paths:
    M llvm/include/llvm/CodeGen/AsmPrinter.h
    M llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
    M llvm/lib/Target/BPF/BPFAsmPrinter.cpp
    M llvm/unittests/CodeGen/AsmPrinterDwarfTest.cpp

  Log Message:
  -----------
  [AsmPrinter] Remove timers (#97046)

Timers are an out-of-line function call and a global variable access,
here twice per emitted instruction. At this granularity, not only the
time results become skewed, but the timers also add a performance
overhead when profiling is disabled. Also outside of the innermost loop,
timers add a measurable overhead. As this is quite expensive for a
mostly unused profiling facility, remove the timers.

Fixes #39650.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list