[all-commits] [llvm/llvm-project] c89f1c: AMDGPU: Fix assert from wrong address space size a...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Mon Jul 1 02:12:01 PDT 2024


  Branch: refs/heads/users/arsenm/amdgpu-codegenprepare-fix-assert-addrspacecast
  Home:   https://github.com/llvm/llvm-project
  Commit: c89f1c2a18574cd4acd4815086dc20dae7b2fd70
      https://github.com/llvm/llvm-project/commit/c89f1c2a18574cd4acd4815086dc20dae7b2fd70
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2024-07-01 (Mon, 01 Jul 2024)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp
    M llvm/test/CodeGen/AMDGPU/codegen-prepare-addrspacecast-non-null.ll

  Log Message:
  -----------
  AMDGPU: Fix assert from wrong address space size assumption

This was assuming the source address space was at least as large
as the destination of the cast. I'm not sure why this was casting
to begin with; the assumption seems to be the source
address space from the root addrspacecast matches the underlying
object so directly check that.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list