[all-commits] [llvm/llvm-project] d2c817: [AMDGPU] Fix DynLDS causing crash when LowerLDS is...

Vigneshwar Jayakumar via All-commits all-commits at lists.llvm.org
Fri Jun 28 19:06:10 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d2c817df846a4fa141778560e2258ab674426f44
      https://github.com/llvm/llvm-project/commit/d2c817df846a4fa141778560e2258ab674426f44
  Author: Vigneshwar Jayakumar <vigneshwarjayakumar at gmail.com>
  Date:   2024-06-28 (Fri, 28 Jun 2024)

  Changed paths:
    M llvm/lib/Target/AMDGPU/Utils/AMDGPUMemoryUtils.cpp
    A llvm/test/CodeGen/AMDGPU/lds-mixed-absolute-dynlds.ll
    M llvm/test/CodeGen/AMDGPU/lds-run-twice.ll

  Log Message:
  -----------
  [AMDGPU] Fix DynLDS causing crash when LowerLDS is run at fullLTO pipeline (#96038)

Direct mapped dynamic LDS is not lowered in the LowerLDSModule pass.
Hence it is not marked with an absolute symbol. When the LowerLDS pass is
rerun in LTO, compilation fails with an assert "cannot mix abs and non-abs LDVs".
This patch adds an additional check for direct mapped dynLDS to skip the assert.

Fixes SWDEV-454281



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list