[all-commits] [llvm/llvm-project] 0cc3fe: Revert "[mlir][NVVM] Disallow results on kernel fu...

[Jeff Niu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0cc3fe460105c4c0c78139d7a78da557c3502298
      https://github.com/llvm/llvm-project/commit/0cc3fe460105c4c0c78139d7a78da557c3502298
  Author: Jeff Niu <jeff at modular.com>
  Date:   2024-06-28 (Fri, 28 Jun 2024)

  Changed paths:
    M mlir/lib/Dialect/LLVMIR/IR/NVVMDialect.cpp
    M mlir/test/Target/LLVMIR/nvvmir.mlir

  Log Message:
  -----------
  Revert "[mlir][NVVM] Disallow results on kernel functions (#96399)" (#97074)

NVVM IR itself doesn't place any restriction that a function annotated
as `nvvm.kernel` actually has no results, so this is a mismatch at the
NVVMDialect level and NVVMIR. The GPU dialect might enforce that kernel
functions have no results, but it doesn't make sense to propagate this
constraint downstream.

Reverts llvm/llvm-project#96399



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications