[all-commits] [llvm/llvm-project] 76864e: [C++20] [Modules] Don't find module for linkage fo...

[Chuanqi Xu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 76864e6af134aa240069d42ba15e0b89fd7d6b4c
      https://github.com/llvm/llvm-project/commit/76864e6af134aa240069d42ba15e0b89fd7d6b4c
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2024-06-28 (Fri, 28 Jun 2024)

  Changed paths:
    M clang/include/clang/AST/DeclBase.h
    M clang/lib/AST/Decl.cpp
    M clang/lib/Sema/SemaLookup.cpp
    A clang/test/Modules/forward-friend.cppm

  Log Message:
  -----------
  [C++20] [Modules] Don't find module for linkage for decls in global
module

Possibly fix https://github.com/llvm/llvm-project/issues/96693

The direct reason is that we are calculating the linkage for the
declaration too early so that the linkage got calculated incorrectly.

And after I look into the problem, I found it is completely not
necessary to calculate the linkage there. It is for ModulesTS. So I
simply removes that legacy experimental code and fix the issue.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications