[all-commits] [llvm/llvm-project] a1bce0: Clang: Add warning flag for storage class specifie...

[David Blaikie via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a1bce0b89e800cb7ab1d3cf3437f8f34d0695468
      https://github.com/llvm/llvm-project/commit/a1bce0b89e800cb7ab1d3cf3437f8f34d0695468
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2024-06-27 (Thu, 27 Jun 2024)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticGroups.td
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/test/CXX/dcl.dcl/dcl.spec/dcl.stc/p1.cpp
    M clang/test/Misc/warning-flags.c
    A clang/test/SemaCXX/warn-explicit-specialization-storage-class.cpp

  Log Message:
  -----------
  Clang: Add warning flag for storage class specifiers on explicit specializations (#96699)

With the recent fix for this situation in class members (#93873) (for
which the fixed code is invalid prior to this patch - making migrating
code difficult as it must be in lock-step with the compiler migration,
if building with -Werror) it'd be really useful to be able to disable
this warning during the compiler migration/decouple the compiler
migration from the source fixes.

In theory this approach will regress the codebase to the previous
non-member cases of this issue that were already being held back by the
warning (as opposed to if we carved out the new cases into a separate
warning from the existing cases) but I think this'll be so rare and the
cleanup so simple, that the extra regressions of disabling the warning
broadly won't be too much of a problem. (but if folks disagree, I'm open
to making the warning more fine-grained)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications