[all-commits] [llvm/llvm-project] 8a7730: [lldb] Don't call AddRemoteRegisters if the target...

[David Spickett via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8a7730fb88445a019fe150d5db4f6642e43afd04
      https://github.com/llvm/llvm-project/commit/8a7730fb88445a019fe150d5db4f6642e43afd04
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2024-06-27 (Thu, 27 Jun 2024)

  Changed paths:
    M lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
    R lldb/test/API/functionalities/gdb_remote_client/TestGDBServerNoTargetXML.py
    A lldb/test/API/functionalities/gdb_remote_client/TestGDBServerNoTargetXMLRegisters.py

  Log Message:
  -----------
  [lldb] Don't call AddRemoteRegisters if the target XML did not include any registers (#96907)

Fixes #92541

When e69a3d18f48bc0d81b5dd12e735a2ec898ce64d added fallback register
layouts, it assumed that the choices were target XML with registers, or
no target XML at all.

In the linked issue, a user has a debug stub that does have target XML,
but it's missing register information.

This caused us to finalize the register information using an empty set
of registers got from target XML, then fail an assert when we attempted
to add the fallback set. Since we think we've already completed the
register information.

This change adds a check to prevent that first call and expands the
existing tests to check each architecture without target XML and with
target XML missing register information.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications