[all-commits] [llvm/llvm-project] d4e9ba: [mlir][OpenMP] Standardise representation of reduc...

[Tom Eccles via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d4e9ba59d6a2e334c983fa79f43b167d0583772b
      https://github.com/llvm/llvm-project/commit/d4e9ba59d6a2e334c983fa79f43b167d0583772b
  Author: Tom Eccles <tom.eccles at arm.com>
  Date:   2024-06-27 (Thu, 27 Jun 2024)

  Changed paths:
    M flang/lib/Lower/OpenMP/ClauseProcessor.cpp
    M mlir/include/mlir/Dialect/OpenMP/OpenMPClauseOperands.h
    M mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td
    M mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
    M mlir/test/Dialect/OpenMP/ops.mlir

  Log Message:
  -----------
  [mlir][OpenMP] Standardise representation of reduction clause (#96215)

Now all operations with a reduction clause have an array of bools
controlling whether each reduction variable should be passed by
reference or value.

This was already supported for Wsloop and Parallel. The new operations
modified here currently have no flang lowering or translation to LLVMIR
and so further changes are not needed.

It isn't possible to check the verifier in
mlir/test/Dialect/OpenMP/invalid.mlir because there is no way of parsing
an operation to have an incorrect number of byref attributes. The
verifier exists to pick up buggy operation builders or in-place
operation modification.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications