[all-commits] [llvm/llvm-project] 73e6f9: gn: hwasan: fixup hwasan-preinit (#96748)

Mitch Phillips via All-commits all-commits at lists.llvm.org
Wed Jun 26 23:03:42 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 73e6f9f95b51d7be1f93deded219005027f8d270
      https://github.com/llvm/llvm-project/commit/73e6f9f95b51d7be1f93deded219005027f8d270
  Author: Mitch Phillips <31459023+hctim at users.noreply.github.com>
  Date:   2024-06-27 (Thu, 27 Jun 2024)

  Changed paths:
    M llvm/utils/gn/secondary/compiler-rt/lib/hwasan/BUILD.gn
    M llvm/utils/gn/secondary/compiler-rt/test/hwasan/BUILD.gn

  Log Message:
  -----------
  gn: hwasan: fixup hwasan-preinit (#96748)

The build rule for hwasan_preinit outputs libclang_rt.hwasan_preinit,
but clang expects hwasan-preinit (with a dash, rather than an
underscore) when selecting the library in the frontend.

Also, we were missing the hwasan-preinit dependency in check-hwasan.

For posterity, this now passes hwasan unit tests on Android with:
 $ cat args.gn
clang_base_path = "/usr/local"
llvm_enable_assertions = true
llvm_targets_to_build = "all"
android_ndk_path = "/path/to/Android.sdk/ndk/25.2.9519653"
 $ /path/to/llvm/utils/gn/gn.py gen build
 $ ANDROID_SERIAL=xxx ninja -C build check-hwasan



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list