[all-commits] [llvm/llvm-project] 70fb1e: Reland [mlir][Target] Improve ROCDL gpu serializat...

[Fabian Mora via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 70fb1e379b52bfab061fd608acb8c7d070d31ecd
      https://github.com/llvm/llvm-project/commit/70fb1e379b52bfab061fd608acb8c7d070d31ecd
  Author: Fabian Mora <fmora.dev at gmail.com>
  Date:   2024-06-25 (Tue, 25 Jun 2024)

  Changed paths:
    M mlir/include/mlir/Target/LLVM/ROCDL/Utils.h
    M mlir/lib/Target/LLVM/CMakeLists.txt
    M mlir/lib/Target/LLVM/ROCDL/Target.cpp

  Log Message:
  -----------
  Reland [mlir][Target] Improve ROCDL gpu serialization API (#96198)

Reland: https://github.com/llvm/llvm-project/pull/95456

This patch improves the ROCDL gpu serialization API by:
- Introducing the enum `AMDGCNLibraries` for specifying the AMD GCN
device code libraries to use during linking.
- Removing `getCommonBitcodeLibs` in favor of `AMDGCNLibraries`.
Previously `getCommonBitcodeLibs` would try to load all AMD GCN bitcode
librariesm now it will only load the requested libraries.
- Exposing the `compileToBinary` method and making it virtual, allowing
downstream users to re-use this method.
- Exposing `moduleToObjectImpl`, this method provides a prototype flow
for compiling to binary, allowing downstream users to re-use this
method.
- It also avoids constructing the control variables if no device
libraries are being used.
- Changes the style of the error messages to be composable, ie no full
stops.
- Adds an error message for when the ROCm toolkit can't be found but it
was required.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications