[all-commits] [llvm/llvm-project] fa2018: [C++20] [Modules] [Serialization] Don't reuse type...

Chuanqi Xu via All-commits all-commits at lists.llvm.org
Tue Jun 25 00:05:27 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fa20184a8f336e4154f2ffeeeb8a538dc9462d9a
      https://github.com/llvm/llvm-project/commit/fa20184a8f336e4154f2ffeeeb8a538dc9462d9a
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2024-06-25 (Tue, 25 Jun 2024)

  Changed paths:
    M clang/lib/Serialization/ASTWriter.cpp
    A clang/test/Modules/no-external-identifier-id.cppm
    A clang/test/Modules/no-external-type-id.cppm

  Log Message:
  -----------
  [C++20] [Modules] [Serialization] Don't reuse type ID and identifier ID from imported modules

To support no-transitive-change model for named modules, we can't reuse
type ID and identifier ID from imported modules arbitrarily. Since the
theory for no-transitive-change model is,
for a user of a named module, the user can only access the
indirectly imported decls via the directly imported module. So that it is
possible to control what matters to the users when writing the module.

And it will be unsafe to do so if the users can reuse the type IDs and
identifier IDs from the indirectly imported modules not via the directly
imported modules.

So in this patch, we don't reuse the type ID and identifier ID in the
AST writer to avoid the problematic case.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list