[all-commits] [llvm/llvm-project] 9e8ccf: [mlir][Conversion] `FuncToLLVM`: Simplify bare-poi...

[Matthias Springer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9e8ccf6b6410a598f94d2ce4c29d753b8609c907
      https://github.com/llvm/llvm-project/commit/9e8ccf6b6410a598f94d2ce4c29d753b8609c907
  Author: Matthias Springer <me at m-sp.org>
  Date:   2024-06-24 (Mon, 24 Jun 2024)

  Changed paths:
    M mlir/lib/Conversion/FuncToLLVM/FuncToLLVM.cpp
    M mlir/lib/Conversion/GPUCommon/GPUOpsLowering.cpp
    M mlir/lib/Conversion/LLVMCommon/TypeConverter.cpp

  Log Message:
  -----------
  [mlir][Conversion] `FuncToLLVM`: Simplify bare-pointer handling (#96393)

Before this commit, there used to be a workaround in the
`func.func`/`gpu.func` op lowering when the bare-pointer calling
convention is enabled. This workaround "patched up" the argument
materializations for memref arguments. This can be done directly in the
argument materialization functions (as the TODOs in the code base
indicate).

This commit effectively reverts back to the old implementation
(a664c14001fa2359604527084c91d0864aa131a4) and adds additional checks to
make sure that bare pointers are used only for function entry block
arguments.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications