[all-commits] [llvm/llvm-project] 1ecc5a: [Serialization] Register Speical types before regi...

[Chuanqi Xu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1ecc5ae13b9061cfb37ef0c409c8a4fc4bad42c9
      https://github.com/llvm/llvm-project/commit/1ecc5ae13b9061cfb37ef0c409c8a4fc4bad42c9
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2024-06-24 (Mon, 24 Jun 2024)

  Changed paths:
    M clang/lib/Serialization/ASTWriter.cpp
    M clang/test/Modules/no-implicit-declarations.cppm
    A clang/test/Modules/no-transitive-decl-change-2.cppm

  Log Message:
  -----------
  [Serialization] Register Speical types before register decls

We will only regsiter top level types and decls in ASTWriter and
we will register the sub types and decls during the process of writing
types and decls. So that the ID for the types in the sub level can be
different if the writing decl process changes the order of the to-be-
emitted type queues. This is not ideal since it causes unnecessary
changes especially in no transitive changes model.

This patch migrates the issue by regsitering special types before
regsitering decls. This make sure that the special types in the 2nd
top level can be registered early than the decls. But it might still be
problematic if there are more levels in the special types. Luckily we
just don't have such special types.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications