[all-commits] [llvm/llvm-project] 3f33d2: [mlir][GPUToNVVM] Fix memref function args/results...

[Matthias Springer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3f33d2f3ca570f1e4e016a07f049724fdff6dad9
      https://github.com/llvm/llvm-project/commit/3f33d2f3ca570f1e4e016a07f049724fdff6dad9
  Author: Matthias Springer <me at m-sp.org>
  Date:   2024-06-23 (Sun, 23 Jun 2024)

  Changed paths:
    M mlir/lib/Conversion/GPUCommon/GPUOpsLowering.cpp
    M mlir/lib/Conversion/GPUCommon/GPUOpsLowering.h
    M mlir/test/Conversion/GPUToNVVM/gpu-to-nvvm.mlir

  Log Message:
  -----------
  [mlir][GPUToNVVM] Fix memref function args/results (#96392)

The `gpu.func` op lowering accounts for memref arguments/results (both
"normal" and bare-pointer supported), but the `gpu.return` op lowering
did not. The lowering produced invalid IR that did not verify.

This commit uses the same lowering strategy as for `func.return` in the
`gpu.return` lowering. (The C++ implementation is copied. We may want to
share some code between `func` and `gpu` lowerings in the future.)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications