[all-commits] [llvm/llvm-project] 2c9c22: [ARM64EC] Fix thunks for vector args (#96003)

[Fangrui Song via All-commits]

  Branch: refs/heads/users/MaskRay/spr/mc-mcfragment-in-bump-allocator
  Home:   https://github.com/llvm/llvm-project
  Commit: 2c9c22c6e295b1176225b63ae4cbbceb216da55e
      https://github.com/llvm/llvm-project/commit/2c9c22c6e295b1176225b63ae4cbbceb216da55e
  Author: Daniel Paoliello <danpao at microsoft.com>
  Date:   2024-06-22 (Sat, 22 Jun 2024)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64Arm64ECCallLowering.cpp
    M llvm/test/CodeGen/AArch64/arm64ec-entry-thunks.ll
    M llvm/test/CodeGen/AArch64/arm64ec-exit-thunks.ll

  Log Message:
  -----------
  [ARM64EC] Fix thunks for vector args (#96003)

The checks when building a thunk to decide if an arg needed to be cast
to/from an integer or redirected via a pointer didn't match how arg
types were changed in `canonicalizeThunkType`, this caused LLVM to ICE
when using vector types as args due to incorrect types in a call
instruction.

Instead of duplicating these checks, we should check if the arg type
differs between x64 and AArch64 and then cast or redirect as
appropriate.


  Commit: 6621505a1eb5428b13d2d29f377050624ef5531c
      https://github.com/llvm/llvm-project/commit/6621505a1eb5428b13d2d29f377050624ef5531c
  Author: Emilia Kond <emilia at rymiel.space>
  Date:   2024-06-22 (Sat, 22 Jun 2024)

  Changed paths:
    M clang/lib/Format/TokenAnnotator.cpp
    M clang/test/Index/overriding-ftemplate-comments.cpp
    M clang/unittests/Format/TokenAnnotatorTest.cpp

  Log Message:
  -----------
  [clang-format] Don't count template template parameter as declaration (#96396)

Reapply 4a7bf42a9b83144db8a11ac06cce4da21166e6a2
which was reverted in 34d44eb41dfbbbf01712719558b02763334fbeb3

Not sure why there are tests elsewhere in clang that rely on the output
of clang-format, but they were wrong


  Commit: ca5ba2e46445caf2c8063a53eb6351fb596190e8
      https://github.com/llvm/llvm-project/commit/ca5ba2e46445caf2c8063a53eb6351fb596190e8
  Author: Sven Verdoolaege <sven at cerebras.net>
  Date:   2024-06-22 (Sat, 22 Jun 2024)

  Changed paths:
    M llvm/include/llvm/Support/FormatProviders.h

  Log Message:
  -----------
  [Support] Avoid warning about possibly uninitialized variable in format_provider (#95704)

The original implementation of HelperFunctions::consumeHexStyle always
sets Style when it returns true, but this is difficult for a compiler
to understand since it requires seeing that Str starts
with either an "x" or an "X" when starts_with_insensitive("x")
return true.
In particular, g++ 12 warns that HS may be used uninitialized
in the format_provider::format caller.

Change HelperFunctions::consumeHexStyle to return an optional
HexPrintStyle and to make the fact that Str necessarily starts
with an "X" when all other cases do not apply more explicit.
This helps both the compiler and the human reader of the code.

Co-authored-by: Sven Verdoolaege <sven.verdoolaege at gmail.com>


  Commit: fc23564c44f3eff1847462253d43c08b85489148
      https://github.com/llvm/llvm-project/commit/fc23564c44f3eff1847462253d43c08b85489148
  Author: Shilei Tian <i at tianshilei.me>
  Date:   2024-06-22 (Sat, 22 Jun 2024)

  Changed paths:
    M llvm/include/llvm/Frontend/OpenMP/OMP.td

  Log Message:
  -----------
  [NFC][Clang][OMPX] Fix a typo in `OMP.td` (#96398)


  Commit: b573263afa992580661029c29267dfa71c0f13c9
      https://github.com/llvm/llvm-project/commit/b573263afa992580661029c29267dfa71c0f13c9
  Author: Fangrui Song <i at maskray.me>
  Date:   2024-06-22 (Sat, 22 Jun 2024)

  Changed paths:
    M clang/lib/Format/TokenAnnotator.cpp
    M clang/test/Index/overriding-ftemplate-comments.cpp
    M clang/unittests/Format/TokenAnnotatorTest.cpp
    M llvm/include/llvm/Frontend/OpenMP/OMP.td
    M llvm/include/llvm/Support/FormatProviders.h
    M llvm/lib/MC/MCContext.cpp
    M llvm/lib/Target/AArch64/AArch64Arm64ECCallLowering.cpp
    M llvm/test/CodeGen/AArch64/arm64ec-entry-thunks.ll
    M llvm/test/CodeGen/AArch64/arm64ec-exit-thunks.ll

  Log Message:
  -----------
  improve comment

Created using spr 1.3.5-bogner


Compare: https://github.com/llvm/llvm-project/compare/7a61f507091e...b573263afa99

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications