[all-commits] [llvm/llvm-project] 0fccae: [clang][utils] Remove ClangDataFormat.py for now (...

Michael Buch via All-commits all-commits at lists.llvm.org
Sat Jun 22 09:07:22 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0fccae9d8e64f3b0f415946000d6ca79ae1255db
      https://github.com/llvm/llvm-project/commit/0fccae9d8e64f3b0f415946000d6ca79ae1255db
  Author: Michael Buch <michaelbuch12 at gmail.com>
  Date:   2024-06-22 (Sat, 22 Jun 2024)

  Changed paths:
    R clang/utils/ClangDataFormat.py

  Log Message:
  -----------
  [clang][utils] Remove ClangDataFormat.py for now (#96385)

This formatter doesn't currently provide much value. It only formats
`SourceLocation` and `QualType`. The only formatting it does for
`QualType` is call `getAsString()` on it.

The main motivator for the removal however is that the formatter
implementation can be very slow (since it uses the expression evaluator
in non-trivial ways).

Not infrequently do we get reports about LLDB being slow when debugging
Clang, and it turns out the user was loading `ClangDataFormat.py` in
their `.lldbinit` by default.

We should eventually develop proper formatters for Clang data-types, but
these are currently not ready. So this patch removes them in the
meantime to avoid users shooting themselves in the foot, and giving the
wrong impression of these being reference implementations.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list