[all-commits] [llvm/llvm-project] 063777: [mlir][LLVMIR][OpenMP] fix dominance for reduction...

[Tom Eccles via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0637778af4174daf9cc1c315049a79db27f36e72
      https://github.com/llvm/llvm-project/commit/0637778af4174daf9cc1c315049a79db27f36e72
  Author: Tom Eccles <tom.eccles at arm.com>
  Date:   2024-06-21 (Fri, 21 Jun 2024)

  Changed paths:
    M mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
    A mlir/test/Target/LLVMIR/openmp-parallel-reduction-multiblock.mlir
    M mlir/test/Target/LLVMIR/openmp-reduction-init-arg.mlir

  Log Message:
  -----------
  [mlir][LLVMIR][OpenMP] fix dominance for reduction init block (#96052)

It was incorrect to set the insertion point to the init block after
inlining the initialization region because the code generated in the
init block depends upon the value yielded from the init region. When
there were multiple reduction initialization regions each with multiple
blocks, this could lead to the initilization region being inlined after
the init block which depends upon it.

Moving the insertion point to before inlining the initialization block
turned up further issues around the handling of the terminator for the
initialization block, which are also fixed here.

This fixes a bug in #92430 (but the affected code couldn't compile
before #92430 anyway).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications