[all-commits] [llvm/llvm-project] 03921b: [serialization] No transitive type change (#92511)

[Med Ismail Bennani via All-commits]

  Branch: refs/heads/revert-94575-crashlog-default-interactive-mode
  Home:   https://github.com/llvm/llvm-project
  Commit: 03921b979d67657bfc9cf8240add2484cc4df6a7
      https://github.com/llvm/llvm-project/commit/03921b979d67657bfc9cf8240add2484cc4df6a7
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2024-06-21 (Fri, 21 Jun 2024)

  Changed paths:
    M clang/include/clang/Serialization/ASTBitCodes.h
    M clang/include/clang/Serialization/ASTReader.h
    M clang/include/clang/Serialization/ASTRecordReader.h
    M clang/include/clang/Serialization/ModuleFile.h
    M clang/lib/Serialization/ASTCommon.cpp
    M clang/lib/Serialization/ASTReader.cpp
    M clang/lib/Serialization/ASTWriter.cpp
    M clang/lib/Serialization/ModuleFile.cpp
    M clang/test/Modules/no-transitive-decls-change.cppm
    M clang/test/Modules/no-transitive-identifier-change.cppm
    A clang/test/Modules/no-transitive-type-change.cppm

  Log Message:
  -----------
  [serialization] No transitive type change (#92511)

Following of https://github.com/llvm/llvm-project/pull/92085. 

#### motivation

The motivation is still cutting of the unnecessary change in the
dependency chain. See the above link (recursively) for details.

And this will be the last patch of the `no-transitive-*-change` series.
If there are any following patches, they might be C++20 Named modules
specific to handle special grammars like `ADL` (See the reply in
https://discourse.llvm.org/t/rfc-c-20-modules-introduce-thin-bmi-and-decls-hash/74755/53
for example). So they won't affect the whole serialization part as the
series patch did.

#### example

After this patch, finally we are able to cut of unnecessary change of
types. For example,

```

//--- m-partA.cppm
export module m:partA;

//--- m-partA.v1.cppm
export module m:partA;

namespace NS {
    class A {
        public:
            int getValue() {
                return 43;
            }
    };
}

//--- m-partB.cppm
export module m:partB;

export inline int getB() {
    return 430;
}

//--- m.cppm
export module m;
export import :partA;
export import :partB;

//--- useBOnly.cppm
export module useBOnly;
import m;

export inline int get() {
    return getB();
}
```

The BMI of `useBOnly.cppm` is expected to not change if we only add a
new class in `m:partA`. This will be pretty useful in practice.

#### implementation details

The key idea of this patch is similar with the previous patches: extend
the 32bits type ID to 64bits so that we can store the module file index
in the higher bits. Then the encoding of the type ID is independent on
the imported modules.

But there are two differences from the previous patches:
- TypeID is not completely an index of serialized types. We used the
lower 3 bits to store the qualifiers.
- TypeID won't take part in any lookup process. So the uses of TypeID is
much less than the previous patches.

The first difference make we have some more slightly complex bit
operations. And the second difference makes the patch much simpler than
the previous ones.


  Commit: 5fbb65ed892418ef52fb9903b91302210ece8ce9
      https://github.com/llvm/llvm-project/commit/5fbb65ed892418ef52fb9903b91302210ece8ce9
  Author: Med Ismail Bennani <ismail at bennani.ma>
  Date:   2024-06-20 (Thu, 20 Jun 2024)

  Changed paths:
    M clang/include/clang/Serialization/ASTBitCodes.h
    M clang/include/clang/Serialization/ASTReader.h
    M clang/include/clang/Serialization/ASTRecordReader.h
    M clang/include/clang/Serialization/ModuleFile.h
    M clang/lib/Serialization/ASTCommon.cpp
    M clang/lib/Serialization/ASTReader.cpp
    M clang/lib/Serialization/ASTWriter.cpp
    M clang/lib/Serialization/ModuleFile.cpp
    M clang/test/Modules/no-transitive-decls-change.cppm
    M clang/test/Modules/no-transitive-identifier-change.cppm
    A clang/test/Modules/no-transitive-type-change.cppm

  Log Message:
  -----------
  Merge branch 'main' into revert-94575-crashlog-default-interactive-mode


Compare: https://github.com/llvm/llvm-project/compare/b9af881866b3...5fbb65ed8924

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications