[all-commits] [llvm/llvm-project] aafa0e: [lldb/crashlog] Make interactive mode the new defa...

[Med Ismail Bennani via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: aafa0ef900791857f55629bcf61c37f53cc0d2af
      https://github.com/llvm/llvm-project/commit/aafa0ef900791857f55629bcf61c37f53cc0d2af
  Author: Med Ismail Bennani <ismail at bennani.ma>
  Date:   2024-06-20 (Thu, 20 Jun 2024)

  Changed paths:
    M lldb/examples/python/crashlog.py
    M lldb/test/Shell/ScriptInterpreter/Python/Crashlog/altered_threadState.test
    M lldb/test/Shell/ScriptInterpreter/Python/Crashlog/json.test
    M lldb/test/Shell/ScriptInterpreter/Python/Crashlog/no_threadState.test
    M lldb/test/Shell/ScriptInterpreter/Python/Crashlog/skipped_status_interactive_crashlog.test
    M lldb/test/Shell/ScriptInterpreter/Python/Crashlog/text.test

  Log Message:
  -----------
  [lldb/crashlog] Make interactive mode the new default (#94575)

This patch makes interactive mode as the default when using the crashlog
command. It replaces the existing `-i|--interactive` flag with a new
`-m|--mode` option, that can either be `interactive` or `batch`.

By default, when the option is not explicitely set by the user, the
interactive mode is selected, however, lldb will fallback to batch mode
if the command interpreter is not interactive or if stdout is not a tty.

This also adds some railguards to prevent users from using interactive
only options with the batch mode and updates the tests accordingly.

rdar://97801509

Differential Revision: https://reviews.llvm.org/D141658

Signed-off-by: Med Ismail Bennani <ismail at bennani.ma>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications