[all-commits] [llvm/llvm-project] 651d44: [clang] Fix missing installed header (#95979)

[Daniel Otero via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 651d44d3dac68192bc4fa37a53e13ae3211c9de0
      https://github.com/llvm/llvm-project/commit/651d44d3dac68192bc4fa37a53e13ae3211c9de0
  Author: Daniel Otero <danielotero at users.noreply.github.com>
  Date:   2024-06-20 (Thu, 20 Jun 2024)

  Changed paths:
    M clang/lib/Headers/CMakeLists.txt

  Log Message:
  -----------
  [clang] Fix missing installed header (#95979)

Since commit 8d468c132eed7ffe34d601b224220efd51655eb3, the header
`openmp_wrappers/complex` is hidden behind `openmp_wrappers/complex.h`
due to a bug in CMake[^1], so is not actually installed.

To test the issue, you can ask `ninja` to generate the file on your
build:

```
$ ninja lib/clang/19/include/openmp_wrappers/complex.h
[199/199] Copying clang's openmp_wrappers/complex.h...
$ ninja lib/clang/19/include/openmp_wrappers/complex
ninja: error: unknown target 'lib/clang/19/include/openmp_wrappers/complex', did you mean 'lib/clang/19/include/openmp_wrappers/complex.h'? 
```

Re-ordering the entries workarounds the issue. The other option is to
revert the cited commit, but I'm not sure which approach is preferred.

CC @etcwilde @jdoerfert 

[^1]: [Here](https://gitlab.kitware.com/cmake/cmake/-/issues/26058) is
the CMake report on the issue.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications