[all-commits] [llvm/llvm-project] 898411: [offload][cmake] always define pythonize_bool macr...

[Wu Yingcong via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 89841137fbb3686673b86af3434bf3ba12993d6d
      https://github.com/llvm/llvm-project/commit/89841137fbb3686673b86af3434bf3ba12993d6d
  Author: Wu Yingcong <yingcong.wu at intel.com>
  Date:   2024-06-20 (Thu, 20 Jun 2024)

  Changed paths:
    M offload/CMakeLists.txt

  Log Message:
  -----------
  [offload][cmake] always define pythonize_bool macro (#96028)

I use the following cmake config to build offload and openmp
```
cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE=Release -DLLVM_TARGETS_TO_BUILD="X86" -DLLVM_ENABLE_PROJECTS="clang;openmp"  -DLLVM_ENABLE_RUNTIMES="offload"  -DLLVM_LIT_ARGS="-vv -a" -DLLVM_ENABLE_ASSERTIONS=ON  ../llvm
```
and got the following error:
```
CMake Error at /tmp/build-llvm/llvm/offload/CMakeLists.txt:321 (pythonize_bool):
  Unknown CMake command "pythonize_bool". 
```

After some search I find out that the "correct" way to build this is
putting openmp and offload to the ENABLE_RUNTIMES like
```
cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE=Release -DLLVM_TARGETS_TO_BUILD="X86" -DLLVM_ENABLE_PROJECTS="clang"  -DLLVM_ENABLE_RUNTIMES="openmp;offload"  -DLLVM_LIT_ARGS="-vv -a" -DLLVM_ENABLE_ASSERTIONS=ON  ../llvm
```
.


But since we don't forbid to config them using openmp as PROJECT and
offload as RUNTIME, then we probably support it. The fix is to always
define the pythonize_bool macro. For cmake, it is okay to redefine a
macro, it does not cause a warning or else.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications