[all-commits] [llvm/llvm-project] 773ee6: [memprof] Rename the members of IndexedMemProfData...

Kazu Hirata via All-commits all-commits at lists.llvm.org
Tue Jun 18 14:24:21 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 773ee62e16b859f41104c53bc3b80fb318d13eb2
      https://github.com/llvm/llvm-project/commit/773ee62e16b859f41104c53bc3b80fb318d13eb2
  Author: Kazu Hirata <kazu at google.com>
  Date:   2024-06-18 (Tue, 18 Jun 2024)

  Changed paths:
    M llvm/include/llvm/ProfileData/MemProf.h
    M llvm/lib/ProfileData/InstrProfWriter.cpp

  Log Message:
  -----------
  [memprof] Rename the members of IndexedMemProfData (NFC) (#94873)

I'm planning to use IndexedMemProfData in MemProfReader and beyond.
Before I do so, this patch renames the members of IndexedMemProfData
as MemProfData.FrameData is a bit mouthful with "Data" repeated twice.

Note that MemProfReader currently has a trio -- IdToFrame,
CSIdToCallStack, and FunctionProfileData.  Replacing them with an
instance of IndexedMemProfData allows us to use the move semantics
from the reader to the writer context.  More importantly, treating the
profile data as one package makes the maintenance easier.  In the
past, forgetting to update a place dealing with the trio has resulted
in a bug where we totally forgot to emit call stacks into the indexed
profile.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list