[all-commits] [llvm/llvm-project] ae0813: Revert "[clang-tidy] fix false positives for the f...

Balazs Benics via All-commits all-commits at lists.llvm.org
Tue Jun 18 00:44:20 PDT 2024 

  Branch: refs/heads/users/steakhal/spr/analyzer-harden-safeguards-for-z3-query-times
  Home:   https://github.com/llvm/llvm-project
  Commit: ae0813f2d7222c4eab7cd3e6099d49f50318d1d5
      https://github.com/llvm/llvm-project/commit/ae0813f2d7222c4eab7cd3e6099d49f50318d1d5
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2024-06-18 (Tue, 18 Jun 2024)

  Changed paths:
    M clang-tools-extra/docs/ReleaseNotes.rst
    M clang-tools-extra/include-cleaner/lib/LocateSymbol.cpp
    M clang-tools-extra/include-cleaner/unittests/FindHeadersTest.cpp
    M clang-tools-extra/test/clang-tidy/checkers/misc/include-cleaner.cpp

  Log Message:
  -----------
  Revert "[clang-tidy] fix false positives for the functions with the same name as standard library functions in misc-include-cleaner (#94923)"

This reverts commit 1bae10879d9183c5edfb709c36b55086ebc772f0. Also add
some test cases to prevent further regressions.


  Commit: d95b82c49aef0223bcc03ff5a9163e70037c82be
      https://github.com/llvm/llvm-project/commit/d95b82c49aef0223bcc03ff5a9163e70037c82be
  Author: Pierre van Houtryve <pierre.vanhoutryve at amd.com>
  Date:   2024-06-18 (Tue, 18 Jun 2024)

  Changed paths:
    M llvm/include/llvm/Target/TargetMachine.h
    M llvm/lib/Target/AMDGPU/AMDGPUSplitModule.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUSplitModule.h
    M llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.h

  Log Message:
  -----------
  [NFC][AMDGPU] Make AMDGPUSplitModule a ModulePass (#95773)

It allows it to access TTI correctly, and opens the door to accessing
more analysis in the future.

I went back and forth between this, and also making the default
SplitModule a Pass too to make it uniform, but I decided against it
because it's just needless complications. Neither llvm-split or
LTOBackend have a PM ready to use so we need to create one anyway. Let's
keep all the mess hidden in the AMDGPU version for now to keep this
change more self-contained.


  Commit: 3ca17443ef4af21bdb1f3b4fbcfff672cbc6176c
      https://github.com/llvm/llvm-project/commit/3ca17443ef4af21bdb1f3b4fbcfff672cbc6176c
  Author: eddyz87 <eddyz87 at gmail.com>
  Date:   2024-06-18 (Tue, 18 Jun 2024)

  Changed paths:
    M llvm/include/llvm/IR/DebugInfoMetadata.h
    M llvm/lib/AsmParser/LLParser.cpp
    M llvm/lib/Bitcode/Reader/MetadataLoader.cpp
    M llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
    M llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
    M llvm/lib/IR/AsmWriter.cpp
    M llvm/lib/IR/DebugInfoMetadata.cpp
    M llvm/lib/IR/LLVMContextImpl.h
    A llvm/test/Bitcode/attr-btf_tag-dibasic.ll
    A llvm/test/Bitcode/attr-btf_tag-disubroutine.ll
    M llvm/test/DebugInfo/attr-btf_type_tag.ll

  Log Message:
  -----------
  [DebugInfo][BPF] Add 'annotations' field for DIBasicType & DISubroutineType (#91422)

Extend `DIBasicType` and `DISubroutineType` with additional field
`annotations`, e.g. as below:

```
  !5 = !DIBasicType(name: "int", size: 32, encoding: DW_ATE_signed, annotations: !6)
  !6 = !{!7}
  !7 = !{!"btf:type_tag", !"tag1"}
```

The field would be used by BPF backend to generate DWARF attributes
corresponding to `btf_type_tag` type attributes, e.g.:

```
  0x00000029:   DW_TAG_base_type
                  DW_AT_name	("int")
                  DW_AT_encoding	(DW_ATE_signed)
                  DW_AT_byte_size	(0x04)

  0x0000002d:     DW_TAG_LLVM_annotation
                    DW_AT_name	("btf:type_tag")
                    DW_AT_const_value	("tag1")
```

Such DWARF entries would be used to generate BTF definitions by tools
like [pahole](https://github.com/acmel/dwarves).

Note: similar fields with similar purposes are already present in
DIDerivedType and DICompositeType.

Currently "btf_type_tag" attributes are represented in debug information
as 'annotations' fields in DIDerivedType with DW_TAG_pointer_type tag.
The annotation on a pointer corresponds to pointee having the attributes
in the final BTF.

The discussion in
[thread](https://lore.kernel.org/bpf/87r0w9jjoq.fsf@oracle.com/) came to
conclusion, that such annotations should apply to the annotated type
itself. Hence the necessity to extend `DIBasicType` & `DISubroutineType`
types with 'annotations' field to represent cases like below:

```
  int __attribute__((btf_type_tag("foo"))) bar;
```

This was previously tracked as differential revision:
https://reviews.llvm.org/D143966


  Commit: db394edf95e7e47e2a11c570d65a8f5005af7849
      https://github.com/llvm/llvm-project/commit/db394edf95e7e47e2a11c570d65a8f5005af7849
  Author: Carlos Alberto Enciso <Carlos.Enciso at sony.com>
  Date:   2024-06-18 (Tue, 18 Jun 2024)

  Changed paths:
    M llvm/bindings/ocaml/debuginfo/debuginfo_ocaml.c
    M llvm/docs/ReleaseNotes.rst
    M llvm/docs/RemoveDIsDebugInfo.md
    M llvm/include/llvm-c/DebugInfo.h
    M llvm/lib/IR/DebugInfo.cpp
    R llvm/test/Bindings/llvm-c/debug_info.ll
    M llvm/test/Bindings/llvm-c/debug_info_new_format.ll
    M llvm/tools/llvm-c-test/debuginfo.c
    M llvm/tools/llvm-c-test/llvm-c-test.h
    M llvm/tools/llvm-c-test/main.c

  Log Message:
  -----------
  [RemoveDIs] Update DIBuilder C API with DbgRecord functions. (#95535)

The DIBuilder C API was changed to deal with DbgRecord functions:

https://github.com/llvm/llvm-project/pull/84915
https://github.com/llvm/llvm-project/pull/85657
https://github.com/llvm/llvm-project/pull/92417#issuecomment-2120078326

As discussed by @nikic and @OCHyams:

https://github.com/llvm/llvm-project/pull/92417#issuecomment-2144505440

> For the intrinsic-inserting functions, do you think we should:
>
> a) mark as deprecated but otherwise leave them alone for now.
> b) mark as deprecated and change their behaviour so that they
>    do nothing and return nullptr.
> c) outright delete them (it sounds like you're voting this one,
>    but just wanted to double check).

This patch implements option (c).


  Commit: 7dd7d5749f7d9d98fec50ee88e633e8b85c6502a
      https://github.com/llvm/llvm-project/commit/7dd7d5749f7d9d98fec50ee88e633e8b85c6502a
  Author: Sirraide <aeternalmail at gmail.com>
  Date:   2024-06-18 (Tue, 18 Jun 2024)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/Sema/SemaExpr.cpp
    M clang/test/C/drs/dr1xx.c
    R clang/test/Sema/debug-93066.cpp
    M clang/test/Sema/exprs.c
    M clang/test/Sema/va_arg_x86_32.c
    M clang/test/SemaObjCXX/sel-address.mm

  Log Message:
  -----------
  Revert "[clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable" (#95833)

Reverts llvm/llvm-project#94159

@zygoloid had some concerns about the implementation of this, which make
sense to me, so Iā€™d like to revert this for now so we can have more time
to think about how to best approach this (if at all...)


  Commit: 89c26f6c7b0a6dfa257ec090fcf5b6e6e0c89aab
      https://github.com/llvm/llvm-project/commit/89c26f6c7b0a6dfa257ec090fcf5b6e6e0c89aab
  Author: Balazs Benics <benicsbalazs at gmail.com>
  Date:   2024-06-18 (Tue, 18 Jun 2024)

  Changed paths:
    M clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h
    A clang/include/clang/StaticAnalyzer/Core/BugReporter/Z3CrosscheckVisitor.h
    M clang/include/clang/StaticAnalyzer/Core/PathSensitive/SMTConstraintManager.h
    M clang/lib/StaticAnalyzer/Core/BugReporter.cpp
    M clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp
    M clang/lib/StaticAnalyzer/Core/CMakeLists.txt
    A clang/lib/StaticAnalyzer/Core/Z3CrosscheckVisitor.cpp
    A clang/test/Analysis/z3/crosscheck-statistics.c
    M clang/unittests/StaticAnalyzer/CMakeLists.txt
    A clang/unittests/StaticAnalyzer/Z3CrosscheckOracleTest.cpp
    M llvm/include/llvm/Support/SMTAPI.h
    M llvm/lib/Support/Z3Solver.cpp

  Log Message:
  -----------
  [analyzer][NFC] Reorganize Z3 report refutation

This change keeps existing behavior, namely that if we hit a Z3 timeout
we will accept the report as "satisfiable".

This prepares for the commit "Harden safeguards for Z3 query times".
https://discourse.llvm.org/t/analyzer-rfc-taming-z3-query-times/79520

Reviewers: NagyDonat, haoNoQ, Xazax-hun, mikhailramalho, Szelethus

Reviewed By: NagyDonat

Pull Request: https://github.com/llvm/llvm-project/pull/95128


  Commit: 00d8d11a2e69a56ea772d742a7028a41c0a4cd4a
      https://github.com/llvm/llvm-project/commit/00d8d11a2e69a56ea772d742a7028a41c0a4cd4a
  Author: Balazs Benics <benicsbalazs at gmail.com>
  Date:   2024-06-18 (Tue, 18 Jun 2024)

  Changed paths:
    M clang-tools-extra/docs/ReleaseNotes.rst
    M clang-tools-extra/include-cleaner/lib/LocateSymbol.cpp
    M clang-tools-extra/include-cleaner/unittests/FindHeadersTest.cpp
    M clang-tools-extra/test/clang-tidy/checkers/misc/include-cleaner.cpp
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/Sema/SemaExpr.cpp
    M clang/test/C/drs/dr1xx.c
    R clang/test/Sema/debug-93066.cpp
    M clang/test/Sema/exprs.c
    M clang/test/Sema/va_arg_x86_32.c
    M clang/test/SemaObjCXX/sel-address.mm
    M llvm/bindings/ocaml/debuginfo/debuginfo_ocaml.c
    M llvm/docs/ReleaseNotes.rst
    M llvm/docs/RemoveDIsDebugInfo.md
    M llvm/include/llvm-c/DebugInfo.h
    M llvm/include/llvm/IR/DebugInfoMetadata.h
    M llvm/include/llvm/Target/TargetMachine.h
    M llvm/lib/AsmParser/LLParser.cpp
    M llvm/lib/Bitcode/Reader/MetadataLoader.cpp
    M llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
    M llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
    M llvm/lib/IR/AsmWriter.cpp
    M llvm/lib/IR/DebugInfo.cpp
    M llvm/lib/IR/DebugInfoMetadata.cpp
    M llvm/lib/IR/LLVMContextImpl.h
    M llvm/lib/Target/AMDGPU/AMDGPUSplitModule.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUSplitModule.h
    M llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.h
    R llvm/test/Bindings/llvm-c/debug_info.ll
    M llvm/test/Bindings/llvm-c/debug_info_new_format.ll
    A llvm/test/Bitcode/attr-btf_tag-dibasic.ll
    A llvm/test/Bitcode/attr-btf_tag-disubroutine.ll
    M llvm/test/DebugInfo/attr-btf_type_tag.ll
    M llvm/tools/llvm-c-test/debuginfo.c
    M llvm/tools/llvm-c-test/llvm-c-test.h
    M llvm/tools/llvm-c-test/main.c

  Log Message:
  -----------
  [š˜€š—½š—æ] changes introduced through rebase

Created using spr 1.3.4

[skip ci]


  Commit: 3813319073ff45a6028956f96daaf3074f583ef8
      https://github.com/llvm/llvm-project/commit/3813319073ff45a6028956f96daaf3074f583ef8
  Author: Balazs Benics <benicsbalazs at gmail.com>
  Date:   2024-06-18 (Tue, 18 Jun 2024)

  Changed paths:
    M clang-tools-extra/docs/ReleaseNotes.rst
    M clang-tools-extra/include-cleaner/lib/LocateSymbol.cpp
    M clang-tools-extra/include-cleaner/unittests/FindHeadersTest.cpp
    M clang-tools-extra/test/clang-tidy/checkers/misc/include-cleaner.cpp
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/Sema/SemaExpr.cpp
    M clang/test/C/drs/dr1xx.c
    R clang/test/Sema/debug-93066.cpp
    M clang/test/Sema/exprs.c
    M clang/test/Sema/va_arg_x86_32.c
    M clang/test/SemaObjCXX/sel-address.mm
    M llvm/bindings/ocaml/debuginfo/debuginfo_ocaml.c
    M llvm/docs/ReleaseNotes.rst
    M llvm/docs/RemoveDIsDebugInfo.md
    M llvm/include/llvm-c/DebugInfo.h
    M llvm/include/llvm/IR/DebugInfoMetadata.h
    M llvm/include/llvm/Target/TargetMachine.h
    M llvm/lib/AsmParser/LLParser.cpp
    M llvm/lib/Bitcode/Reader/MetadataLoader.cpp
    M llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
    M llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
    M llvm/lib/IR/AsmWriter.cpp
    M llvm/lib/IR/DebugInfo.cpp
    M llvm/lib/IR/DebugInfoMetadata.cpp
    M llvm/lib/IR/LLVMContextImpl.h
    M llvm/lib/Target/AMDGPU/AMDGPUSplitModule.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUSplitModule.h
    M llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.h
    R llvm/test/Bindings/llvm-c/debug_info.ll
    M llvm/test/Bindings/llvm-c/debug_info_new_format.ll
    A llvm/test/Bitcode/attr-btf_tag-dibasic.ll
    A llvm/test/Bitcode/attr-btf_tag-disubroutine.ll
    M llvm/test/DebugInfo/attr-btf_type_tag.ll
    M llvm/tools/llvm-c-test/debuginfo.c
    M llvm/tools/llvm-c-test/llvm-c-test.h
    M llvm/tools/llvm-c-test/main.c

  Log Message:
  -----------
  Landed first commit

Created using spr 1.3.4


Compare: https://github.com/llvm/llvm-project/compare/f2b4dd47c0d2...3813319073ff

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications

More information about the All-commits mailing list