[all-commits] [llvm/llvm-project] 2cf2f1: [libc++] Test suite adjustments on macOS (#95835)

Louis Dionne via All-commits all-commits at lists.llvm.org
Mon Jun 17 17:36:37 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2cf2f1b2b6219b606faeade2342c3d2288658ab0
      https://github.com/llvm/llvm-project/commit/2cf2f1b2b6219b606faeade2342c3d2288658ab0
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2024-06-17 (Mon, 17 Jun 2024)

  Changed paths:
    M libcxx/cmake/caches/Apple.cmake
    R libcxx/test/configs/apple-libc++-shared.cfg.in
    M libcxx/test/libcxx/input.output/iostream.format/output.streams/ostream.formatted/ostream.formatted.print/vprint_unicode.pass.cpp
    M libcxx/utils/ci/apple-install-libcxx.sh
    R libcxxabi/test/configs/apple-libc++abi-shared.cfg.in

  Log Message:
  -----------
  [libc++] Test suite adjustments on macOS (#95835)

This patch makes a few adjustments to the way we run the tests in the
Apple configuration on macOS:

First, we stop using DYLD_LIBRARY_PATH. Using that environment variable
leads to libc++.dylib being replaced by the just-built one for the whole
process, and that assumes compatibility between the system-provided
dylib and the just-built one. Unfortunately, that is not the case
anymore due to typed allocation, which is only available in the system
one. Instead, we want to layer the just-built libc++ on top of the
system-provided one, which seems to be what happens when we set a rpath
instead.

Second, add a missing XFAIL for a std::print test that didn't work as
expected when building with availability annotations enabled. When we
enable these annotations, std::print falls back to a non-unicode and
non-terminal output, which breaks the test.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list