[all-commits] [llvm/llvm-project] af893d: AMDGPU: Remove .v2bf16 buffer atomic fadd intrinsics

Matt Arsenault via All-commits all-commits at lists.llvm.org
Mon Jun 17 10:38:32 PDT 2024


  Branch: refs/heads/users/arsenm/amdgpu-remove-buffer-atomic-fadd-v2bf16-intrinsics
  Home:   https://github.com/llvm/llvm-project
  Commit: af893d9fdfc80c83a7baa1e9d8bcd5c6eae7931e
      https://github.com/llvm/llvm-project/commit/af893d9fdfc80c83a7baa1e9d8bcd5c6eae7931e
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2024-06-17 (Mon, 17 Jun 2024)

  Changed paths:
    M llvm/include/llvm/IR/IntrinsicsAMDGPU.td
    M llvm/lib/Target/AMDGPU/AMDGPUGISel.td
    M llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUISelLowering.h
    M llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
    M llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUSearchableTables.td
    M llvm/lib/Target/AMDGPU/BUFInstructions.td
    M llvm/lib/Target/AMDGPU/SIISelLowering.cpp
    M llvm/lib/Target/AMDGPU/SIInstrInfo.td
    M llvm/lib/Target/AMDGPU/SIInstructions.td
    M llvm/test/CodeGen/AMDGPU/fp-atomics-gfx1200.ll

  Log Message:
  -----------
  AMDGPU: Remove .v2bf16 buffer atomic fadd intrinsics

These are redundant with the unsuffixed versions, and have a name
collision with surprising behavior when the base intrinsic is used with
v2bf16.

The global and flat variants should be removed too, but those are complicated
due to using v2i16 in place of the natural v2bf16. Those cases can soon be
completely deleted in favor of atomicrmw.

The GlobalISel codegen change is broken and substitutes handling as bf16
for handling as f16, but it's a bug that this passed the IRTranslator in the first
place.


  Commit: c70f42b1cd4b789dc9f3142cecffaa902cb0dbbc
      https://github.com/llvm/llvm-project/commit/c70f42b1cd4b789dc9f3142cecffaa902cb0dbbc
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2024-06-17 (Mon, 17 Jun 2024)

  Changed paths:
    M llvm/test/CodeGen/AMDGPU/llvm.amdgcn.ptr.buffer.atomic.fadd_rtn_errors.ll

  Log Message:
  -----------
  bf16 errors are now broken in globalisel


Compare: https://github.com/llvm/llvm-project/compare/fb5e46d0b58c...c70f42b1cd4b

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list