[all-commits] [llvm/llvm-project] fb5e46: AMDGPU: Remove .v2bf16 buffer atomic fadd intrinsics

Matt Arsenault via All-commits all-commits at lists.llvm.org
Mon Jun 17 06:25:47 PDT 2024


  Branch: refs/heads/users/arsenm/amdgpu-remove-raw-buffer-atomic-fadd-v2bf16-intrinsic
  Home:   https://github.com/llvm/llvm-project
  Commit: fb5e46d0b58c616c2ded261a8e3aa32a940380f2
      https://github.com/llvm/llvm-project/commit/fb5e46d0b58c616c2ded261a8e3aa32a940380f2
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2024-06-17 (Mon, 17 Jun 2024)

  Changed paths:
    M llvm/include/llvm/IR/IntrinsicsAMDGPU.td
    M llvm/lib/Target/AMDGPU/AMDGPUGISel.td
    M llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUISelLowering.h
    M llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
    M llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUSearchableTables.td
    M llvm/lib/Target/AMDGPU/BUFInstructions.td
    M llvm/lib/Target/AMDGPU/SIISelLowering.cpp
    M llvm/lib/Target/AMDGPU/SIInstrInfo.td
    M llvm/lib/Target/AMDGPU/SIInstructions.td
    M llvm/test/CodeGen/AMDGPU/fp-atomics-gfx1200.ll

  Log Message:
  -----------
  AMDGPU: Remove .v2bf16 buffer atomic fadd intrinsics

These are redundant with the unsuffixed versions, and have a name
collision with surprising behavior when the base intrinsic is used with
v2bf16.

The global and flat variants should be removed too, but those are complicated
due to using v2i16 in place of the natural v2bf16. Those cases can soon be
completely deleted in favor of atomicrmw.

The GlobalISel codegen change is broken and substitutes handling as bf16
for handling as f16, but it's a bug that this passed the IRTranslator in the first
place.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list