[all-commits] [llvm/llvm-project] cc7a18: Set Support system_libs if WIN32, not just MSVC or...

Jeremy Day via All-commits all-commits at lists.llvm.org
Fri Jun 14 12:18:01 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cc7a18c18011d1e0c70187ceb60e3e69bf7cd0ee
      https://github.com/llvm/llvm-project/commit/cc7a18c18011d1e0c70187ceb60e3e69bf7cd0ee
  Author: Jeremy Day <jeremy at thebrowser.company>
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
    M llvm/lib/Support/CMakeLists.txt

  Log Message:
  -----------
  Set Support system_libs if WIN32, not just MSVC or MINGW (#95505)

The previous check was false when compiling with `clang++`, which
prevented `ntdll` from being specified as a link library, causing an
undefined symbol error when trying to resolve `RtlGetLastNtStatus`.
Since we always want to link these libraries on Windows, the check can
be simplified to just `if( WIN32 )`.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list