[all-commits] [llvm/llvm-project] db3a47: Fix silent truncation of inline ASM `srcloc` cooki...

beetrees via All-commits all-commits at lists.llvm.org
Fri Jun 14 07:06:19 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: db3a47c810639388c80ed173dda3623dac00ce0a
      https://github.com/llvm/llvm-project/commit/db3a47c810639388c80ed173dda3623dac00ce0a
  Author: beetrees <b at beetr.ee>
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
    M clang/lib/CodeGen/CGCall.cpp
    M clang/test/CodeGen/attr-error.c
    M clang/test/CodeGen/attr-warning.c
    M llvm/docs/LangRef.rst
    M llvm/include/llvm/IR/DiagnosticInfo.h
    M llvm/lib/CodeGen/MachineModuleInfo.cpp
    M llvm/lib/IR/DiagnosticInfo.cpp

  Log Message:
  -----------
  Fix silent truncation of inline ASM `srcloc` cookie when going through a `DiagnosticInfoSrcMgr` (#84559)

The size of the inline ASM `srcloc` cookie was changed from 32 bits to
64 bits in [D105491](https://reviews.llvm.org/D105491). However, that
commit only updated the size of the cookie in `DiagnosticInfoInlineAsm`,
meaning that inline ASM diagnostics that are instead represented with a
`DiagnosticInfoSrcMgr` have their cookies truncated to 32 bits. This PR
replaces the remaining uses of `unsigned` to represent the cookie with
`uint64_t`, allowing the cookie to make it all the way to the diagnostic
handler without being truncated.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list