[all-commits] [llvm/llvm-project] d890dd: [NFCI][AMDGPU] Try to use PressureDiff to Calculat...

[Pierre van Houtryve via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d890dda16bf65bc36b783194afbe2ebc3e709afb
      https://github.com/llvm/llvm-project/commit/d890dda16bf65bc36b783194afbe2ebc3e709afb
  Author: Pierre van Houtryve <pierre.vanhoutryve at amd.com>
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
    M llvm/lib/Target/AMDGPU/GCNSchedStrategy.cpp
    M llvm/lib/Target/AMDGPU/GCNSchedStrategy.h

  Log Message:
  -----------
  [NFCI][AMDGPU] Try to use PressureDiff to Calculate RegPressure. (#94221)

PressureDiff is reliable most of the time, and it's pretty much free
compared to RPTracker. We can use it whenever there is no subregister
definitions, or physregs invovled. No subregs because PDiff doesn't take
into account lane liveness, and no Physreg because it seems to get
PhysReg liveness completely wrong. Sometimes it adds a diff, sometimes
itt doesn't - I didn't look at that one for long so maybe there is
something we can eventually do to make it better.

This allows us to save a ton of calls to RPTracker and LIS too. On a
huge IR module (100+MB), it went from about 20M calls to RPTracker in this
function down to 3.4, with the rest being PressureDiffs.

I also added an expensive check to verify correctness of PressureDiff.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications