[all-commits] [llvm/llvm-project] acb8f3: Address review feedback.

[Ahmed Bougacha via All-commits]

  Branch: refs/heads/users/ahmedbougacha/ptrauth-siphash
  Home:   https://github.com/llvm/llvm-project
  Commit: acb8f3c319165bac2315cabe735cd8beccac046e
      https://github.com/llvm/llvm-project/commit/acb8f3c319165bac2315cabe735cd8beccac046e
  Author: Ahmed Bougacha <ahmed at bougacha.org>
  Date:   2024-06-05 (Wed, 05 Jun 2024)

  Changed paths:
    M llvm/lib/Support/SipHash.cpp

  Log Message:
  -----------
  Address review feedback.

- add back github link to ref. impl.
- add back function doc comment
- use anon. namespace
- use constexpr outlen, avoid or workaround


  Commit: 644b473fa7d0382b035d4dfd2ea4ed88fcd97233
      https://github.com/llvm/llvm-project/commit/644b473fa7d0382b035d4dfd2ea4ed88fcd97233
  Author: Ahmed Bougacha <ahmed at bougacha.org>
  Date:   2024-06-11 (Tue, 11 Jun 2024)

  Changed paths:
    M llvm/lib/Support/SipHash.cpp

  Log Message:
  -----------
  Return result indirectly to bring back big-endian host support.

Use endian::support to do the appropriate swaps.

Returning the result as a value was convenient but int128 types and
big-endian hosts don't mix well.  We don't have 128-bit byteswap, and
it's not something that would even be usable, because int128 can be
returned with the 64-bit halves in little-endian order.  I don't know
that we can confidently rely on this being always true, so just define
away this whole problem; we don't need the doubled/16-byte result here
anyway.


  Commit: 9a4f5776c2db9dfc7252cd3d17b8b80cd580f87a
      https://github.com/llvm/llvm-project/commit/9a4f5776c2db9dfc7252cd3d17b8b80cd580f87a
  Author: Ahmed Bougacha <ahmed at bougacha.org>
  Date:   2024-06-11 (Tue, 11 Jun 2024)

  Changed paths:
    M llvm/lib/Support/SipHash.cpp

  Log Message:
  -----------
  Merge branch 'integrate-siphash-into-libsupport' into ptrauth-siphash

Conflicts:
      llvm/lib/Support/SipHash.cpp


Compare: https://github.com/llvm/llvm-project/compare/bf413d68cff5...9a4f5776c2db

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications