[all-commits] [llvm/llvm-project] 16f2aa: [libc++] Tweak how we check constraints on shared_...

Louis Dionne via All-commits all-commits at lists.llvm.org
Tue Jun 11 13:45:33 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 16f2aa1a2ddfcb99e34da5af9d75eaeeb97bb9ce
      https://github.com/llvm/llvm-project/commit/16f2aa1a2ddfcb99e34da5af9d75eaeeb97bb9ce
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2024-06-11 (Tue, 11 Jun 2024)

  Changed paths:
    M libcxx/include/__memory/shared_ptr.h
    M libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/nullptr_t_deleter.pass.cpp
    M libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/nullptr_t_deleter_allocator.pass.cpp
    M libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/pointer_deleter.pass.cpp
    M libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/pointer_deleter_allocator.pass.cpp

  Log Message:
  -----------
  [libc++] Tweak how we check constraints on shared_ptr(nullptr_t) (#94996)

This avoids breaking code that should arguably be valid but technically
isn't after enforcing the constraints on shared_ptr's constructors. A
new LWG issue was filed to fix this in the Standard.

This patch applies the expected resolution of this issue to avoid
flip-flopping users whose code should always be considered valid.

See #93071 for more context.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list